Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328864: NullPointerException in sun.security.jca.ProviderList.getService() #3442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Apr 4, 2025

Backporting JDK-8328864: NullPointerException in sun.security.jca.ProviderList.getService(). Updated getService to check whether getProvider returns null when checking for preferred providers, continuing the loop if so. Added NullPreferredList test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328864 needs maintainer approval

Issue

  • JDK-8328864: NullPointerException in sun.security.jca.ProviderList.getService() (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3442/head:pull/3442
$ git checkout pull/3442

Update a local copy of the PR:
$ git checkout pull/3442
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3442

View PR using the GUI difftool:
$ git pr show -t 3442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3442.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport cd3a607576bede17f48c3d5ebde2bf05f3b615ba 8328864: NullPointerException in sun.security.jca.ProviderList.getService() Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@satyenme
Copy link
Author

satyenme commented Apr 4, 2025

/approval request for backport. Updated getService to check whether getProvider returns null when checking for preferred providers, continuing the loop if so. Added NullPreferredList test.

Risk: Low. Tip change was merged in May 2024 and adds conditional statement to catch exception case, otherwise preserving functionality. Further, new test explicitly confirms altered functionality.

Testing:

  • GHA Sanity Checks
  • Tier 1 and 2 tests locally

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@satyenme
8328864: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant