Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms #3438

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 4, 2025

Follow up to 8258483 to fix PPC


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339300 needs maintainer approval

Issue

  • JDK-8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3438/head:pull/3438
$ git checkout pull/3438

Update a local copy of the PR:
$ git checkout pull/3438
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3438

View PR using the GUI difftool:
$ git pr show -t 3438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3438.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3437 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f2c992c5af021ab0ff8429fd261314bc7e01f7df 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@openjdk openjdk bot added approval and removed approval labels Apr 5, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@GoeLin This pull request has not yet been marked as ready for integration.

@GoeLin GoeLin changed the base branch from pr/3437 to master April 7, 2025 15:05
@openjdk openjdk bot removed the clean label Apr 7, 2025
@openjdk openjdk bot added clean ready Pull request is ready to be integrated labels Apr 7, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit b7a846d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@GoeLin Pushed as commit b7a846d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8339300 branch April 7, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant