Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353714: [17u] Backport of 8347740 incomplete #3435

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 4, 2025

Fix test issue. The old call to the test should have been removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8353714 needs maintainer approval

Issue

  • JDK-8353714: [17u] Backport of 8347740 incomplete (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3435/head:pull/3435
$ git checkout pull/3435

Update a local copy of the PR:
$ git checkout pull/3435
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3435

View PR using the GUI difftool:
$ git pr show -t 3435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3435.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353714: [17u] Backport of 8347740 incomplete

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 729b0c7: 8352649: [17u] guarantee(is_result_safe || is_in_asgct()) failed inside AsyncGetCallTrace
  • bb103d7: 8298730: Refactor subsystem_file_line_contents and add docs and tests
  • c98e598: 8350412: [21u] AArch64: Ambiguous frame layout leads to incorrect traces in JFR

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title [17u] Backport of 8347740 incomplete 8353714: [17u] Backport of 8347740 incomplete Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 7, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit 8c5fa69.
Since your change was applied there have been 11 commits pushed to the master branch:

  • c8ac6fd: 8340437: Open source few more AWT Frame related tests
  • 51a7918: 8340874: Open source some of the AWT Geometry/Button tests
  • 6c1f3db: 8340271: Open source several AWT Robot tests
  • 98f87f6: 8339148: Make os::Linux::active_processor_count() public
  • b7a846d: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
  • 4d51cd8: 8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small
  • 36e703a: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
  • 95e6cbd: 8315871: Opensource five more Swing regression tests
  • 729b0c7: 8352649: [17u] guarantee(is_result_safe || is_in_asgct()) failed inside AsyncGetCallTrace
  • bb103d7: 8298730: Refactor subsystem_file_line_contents and add docs and tests
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/025da55defb4428a0cbc75b24842513011f1220d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@GoeLin Pushed as commit 8c5fa69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_8353714 branch April 7, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants