Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343101: Rework BasicTest.testTemp test cases #3176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 27, 2024

I backport this for parity with 17.0.15-oracle.

This is based on the commit to 21. I needed to resolve again, though:
https://bugs.openjdk.org/browse/JDK-8291978: jpackage: allow to override primary l10n files on Windows is not in 17.

I include some of the edits of 8291978 in this change, as they nicely clean up the test code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8343101 needs maintainer approval
  • JDK-8343178 needs maintainer approval
  • Commit message must refer to an issue

Issues

  • JDK-8343101: Rework BasicTest.testTemp test cases (Enhancement - P4 - Requested)
  • JDK-8343178: Test BasicTest.java javac compile fails cannot find symbol (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3176/head:pull/3176
$ git checkout pull/3176

Update a local copy of the PR:
$ git checkout pull/3176
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3176

View PR using the GUI difftool:
$ git pr show -t 3176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3176.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 27, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fe9284a8c523bc747e107836c85114864efab2a1 8343101: Rework BasicTest.testTemp test cases Dec 27, 2024
@openjdk
Copy link

openjdk bot commented Dec 27, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 27, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Dec 30, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants