8343101: Rework BasicTest.testTemp test cases #3176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 17.0.15-oracle.
This is based on the commit to 21. I needed to resolve again, though:
https://bugs.openjdk.org/browse/JDK-8291978: jpackage: allow to override primary l10n files on Windows is not in 17.
I include some of the edits of 8291978 in this change, as they nicely clean up the test code.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3176/head:pull/3176
$ git checkout pull/3176
Update a local copy of the PR:
$ git checkout pull/3176
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3176/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3176
View PR using the GUI difftool:
$ git pr show -t 3176
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3176.diff
Using Webrev
Link to Webrev Comment