Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java #3175

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 27, 2024

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8332158 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3175/head:pull/3175
$ git checkout pull/3175

Update a local copy of the PR:
$ git checkout pull/3175
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3175

View PR using the GUI difftool:
$ git pr show -t 3175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3175.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 27, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 81d7b70: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
  • 3bc06ab: 8341424: GHA: Collect hs_errs from build time failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b1b4cd429a4135840966975dd0c068fe428e2ee6 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java Dec 27, 2024
@openjdk
Copy link

openjdk bot commented Dec 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 27, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 27, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Dec 29, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 30, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 30, 2024

Going to push as commit 65fde36.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 5adbdac: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
  • 2171eda: 8316146: Open some swing tests 4
  • 6f0f175: 8316371: Open some swing tests 6
  • 7625c82: 8316218: Open some swing tests 5
  • 1d525cc: 8315882: Open some swing tests 2
  • 487b9a5: 8315825: Open some swing tests
  • 81d7b70: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
  • 3bc06ab: 8341424: GHA: Collect hs_errs from build time failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2024
@openjdk openjdk bot closed this Dec 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 30, 2024
@openjdk
Copy link

openjdk bot commented Dec 30, 2024

@GoeLin Pushed as commit 65fde36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant