Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 21, 2025

Hi all,

This pull request contains a backport of commit fdb74ed4 from the openjdk/jdk repository.

The commit being backported was authored by Phil Race on 13 Oct 2022 and was reviewed by David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8295301 needs maintainer approval

Issue

  • JDK-8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3100/head:pull/3100
$ git checkout pull/3100

Update a local copy of the PR:
$ git checkout pull/3100
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3100

View PR using the GUI difftool:
$ git pr show -t 3100

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3100.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fdb74ed45240477bd08eb40ede5eaa2345ca6b5d 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04 Sep 21, 2025
@openjdk
Copy link

openjdk bot commented Sep 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 21, 2025
@mrserb mrserb marked this pull request as ready for review September 23, 2025 21:56
@mrserb
Copy link
Member Author

mrserb commented Sep 23, 2025

/approval request
Clean backport. A few tests were added to the problem list. All of them fail on JDK 11, same as on 17+.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@mrserb
8295301: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 23, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant