Skip to content

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Sep 10, 2025

Backport fixes compiler warning on newer gcc. (Also has been backported to oracle jdk 11)

Backport was clean except for copyright header.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8286694 needs maintainer approval

Issue

  • JDK-8286694: Incorrect argument processing in java launcher (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3092/head:pull/3092
$ git checkout pull/3092

Update a local copy of the PR:
$ git checkout pull/3092
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3092/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3092

View PR using the GUI difftool:
$ git pr show -t 3092

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3092.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2025

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 651ba865c1afe2b29adc5b0ca428117200313912 8286694: Incorrect argument processing in java launcher Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant