8286562: GCC 12 reports some compiler warnings #3091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fixes few warnings in newer gcc (12+), which I have seen some when doing test build for gcc15 (fedora 42) for another backport. Warning do not show in current GHA runs because it uses gcc 10. (Btw this change has also been backported to oracle jdk 11.)
Backport is not clear, there were some differences in surrounding context, copyright headers, location of gmk file etc. So part of it had to be done manually. Changes to jfrTraceIdBits.inline.hpp are not present, because modified function is not present on jdk11.
I also included backport of followup change (JDK-8293691), which fixes problem introduced by original backported change.
GHA tests: OK
Progress
Warning
8293691: converting a defined BasicType value to a string should not crash the VM
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3091/head:pull/3091
$ git checkout pull/3091
Update a local copy of the PR:
$ git checkout pull/3091
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3091/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3091
View PR using the GUI difftool:
$ git pr show -t 3091
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3091.diff
Using Webrev
Link to Webrev Comment