Skip to content

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Sep 10, 2025

Backport fixes few warnings in newer gcc (12+), which I have seen some when doing test build for gcc15 (fedora 42) for another backport. Warning do not show in current GHA runs because it uses gcc 10. (Btw this change has also been backported to oracle jdk 11.)

Backport is not clear, there were some differences in surrounding context, copyright headers, location of gmk file etc. So part of it had to be done manually. Changes to jfrTraceIdBits.inline.hpp are not present, because modified function is not present on jdk11.

I also included backport of followup change (JDK-8293691), which fixes problem introduced by original backported change.

GHA tests: OK


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8293691 needs maintainer approval
  • Change must not contain extraneous whitespace
  • JDK-8286562 needs maintainer approval
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8293691: converting a defined BasicType value to a string should not crash the VM

Issues

  • JDK-8286562: GCC 12 reports some compiler warnings (Bug - P4)
  • JDK-8293691: converting a defined BasicType value to a string should not crash the VM (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3091/head:pull/3091
$ git checkout pull/3091

Update a local copy of the PR:
$ git checkout pull/3091
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3091

View PR using the GUI difftool:
$ git pr show -t 3091

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3091.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2025

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@zzambers zzambers changed the title Backport f2a32d996ae09620474771c46a649f6c4e1148ad Backport 410a25d59a11b6a627bbb0a2c405c2c2be19f464 Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 410a25d59a11b6a627bbb0a2c405c2c2be19f464 8286562: GCC 12 reports some compiler warnings Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 10, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2025

Webrevs

@zzambers
Copy link
Contributor Author

/issue add JDK-8293691

@openjdk
Copy link

openjdk bot commented Sep 10, 2025

@zzambers
Adding additional issue to issue list: 8293691: converting a defined BasicType value to a string should not crash the VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant