Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216539: tools/jar/modularJar/Basic.java timed out #2981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 24, 2024

Hi all,

This pull request contains a backport of commit 518e3a87 from the openjdk/jdk repository.

This PR fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8216539 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8216539: tools/jar/modularJar/Basic.java timed out (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2981/head:pull/2981
$ git checkout pull/2981

Update a local copy of the PR:
$ git checkout pull/2981
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2981/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2981

View PR using the GUI difftool:
$ git pr show -t 2981

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2981.diff

Using Webrev

Link to Webrev Comment

Reviewed-by: mchung, alanb, bchristi, bpb
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 518e3a878862fd7be2d9eea42f122fdaa01c7dd8 8216539: tools/jar/modularJar/Basic.java timed out Dec 24, 2024
@openjdk
Copy link

openjdk bot commented Dec 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2024

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 2 failures:

  1. Job linux-x64 / build - Build / test fails at Get JTReg stage, report wget exited with exit code 4, seems like infrastructure or environmental issue, it's unrelated this PR.
  2. Job linux-x64-hs-nopch / build - Build / test fails at Get JTReg stage, report wget exited with exit code 4, seems like infrastructure or environmental issue, it's unrelated this PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which cause test intermittent fails. The change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

@sendaoYan
8216539: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant