-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ #2969
base: master
Are you sure you want to change the base?
8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ #2969
Conversation
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval 8301753 request Clean backport to 11u. This fixes "make run-test-prebuilt" build problem occured with make version <4.0 in JDK11. |
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Clean backport to 11u.
This fixes "make test" build problem occured with make version <4.0 in JDK11.
The new test is passed locally with a manual run with both "GNU Make 3.82" and "GNU Make 4.3".
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2969/head:pull/2969
$ git checkout pull/2969
Update a local copy of the PR:
$ git checkout pull/2969
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2969/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2969
View PR using the GUI difftool:
$ git pr show -t 2969
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2969.diff
Using Webrev
Link to Webrev Comment