Skip to content

Conversation

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Dec 23, 2025

Please, review a simple fix for a jdk 26 regression: JDK-8364343. It will be pushed to 27 first and then back ported to 26.
This issue impacts JVM TI scalability. The JDK-8364343 replaced the overloaded ctor MountUnmountDisabler(jthread thread) with MountUnmountDisabler(oop thread_oop). This caused the most common JVM TI pattern MountUnmountDisabler disabler(thread) (where thread is a jthread) to be resolved to MountUnmountDisabler(bool exclusive). It makes the instantiated MountUnmountDisabler to disable mount/unmount transitions for all virtual thread instead of the specific one. This problem was identified with a minor tracing.

The fix restores the original ctor MountUnmountDisabler(jthread thread).

Testing:

  • TBD: run mach5 tiers 1-6

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374233: Overloaded constructor MountUnmountDisabler(jthread thread) is missed (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28965/head:pull/28965
$ git checkout pull/28965

Update a local copy of the PR:
$ git checkout pull/28965
$ git pull https://git.openjdk.org/jdk.git pull/28965/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28965

View PR using the GUI difftool:
$ git pr show -t 28965

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28965.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374233: Overloaded constructor MountUnmountDisabler(jthread thread) is missed

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 220 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@sspitsyn
Copy link
Contributor Author

/label add serviceability

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn
The label rfr is not a valid label.
These labels are valid:

  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@mlbridge
Copy link

mlbridge bot commented Dec 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2025
@sspitsyn
Copy link
Contributor Author

Chris and Alex, thank you for review!

@sspitsyn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

Going to push as commit f5249db.
Since your change was applied there have been 221 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2025
@openjdk openjdk bot closed this Dec 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn Pushed as commit f5249db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn
Copy link
Contributor Author

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn the backport was successfully created on the branch backport-sspitsyn-f5249db9-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f5249db9 from the openjdk/jdk repository.

The commit being backported was authored by Serguei Spitsyn on 23 Dec 2025 and was reviewed by Chris Plummer and Alex Menkov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-sspitsyn-f5249db9-jdk26:backport-sspitsyn-f5249db9-jdk26
$ git checkout backport-sspitsyn-f5249db9-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-sspitsyn-f5249db9-jdk26

⚠️ @sspitsyn You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

@sspitsyn sspitsyn deleted the f11 branch December 23, 2025 22:47
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@sspitsyn The command label can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants