Skip to content

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Dec 23, 2025

In src/hotspot/os/linux/os_linux.cpp this comment no longer shows where there is time support code:

////////////////////////////////////////////////////////////////////////////////
// time support

Orphaned since JDK-8372625, trivially remove.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374296: Comment clean up in os_linux.cpp (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28963/head:pull/28963
$ git checkout pull/28963

Update a local copy of the PR:
$ git checkout pull/28963
$ git pull https://git.openjdk.org/jdk.git pull/28963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28963

View PR using the GUI difftool:
$ git pr show -t 28963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28963.diff

Using Webrev

Link to Webrev Comment

@kevinjwalls kevinjwalls marked this pull request as ready for review December 23, 2025 12:22
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374296: Comment clean up in os_linux.cpp

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f1c5041: 8374200: jdk/internal/platform/cgroup/TestCgroupMetrics.java fails with common prefix metrics
  • 40755af: 8373808: Refactor java/net/httpclient qpack and hpack tests to use JUnit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@kevinjwalls The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial. Thanks for cleaning it up!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2025
@kevinjwalls
Copy link
Contributor Author

Thanks!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

Going to push as commit 8d80bac.
Since your change was applied there have been 3 commits pushed to the master branch:

  • be2ac08: 8373967: [macos] User interactions with List do not trigger ItemEvent after programmatic change
  • f1c5041: 8374200: jdk/internal/platform/cgroup/TestCgroupMetrics.java fails with common prefix metrics
  • 40755af: 8373808: Refactor java/net/httpclient qpack and hpack tests to use JUnit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2025
@openjdk openjdk bot closed this Dec 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@kevinjwalls Pushed as commit 8d80bac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants