Skip to content

8373475: Unintentional format string in logString of AccessInfo.cpp #28950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DamonGuy wants to merge 4 commits into from
+2 −3
Closed

8373475: Unintentional format string in logString of AccessInfo.cpp #28950

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6e8961
Initial commit
DamonGuy Dec 22, 2025
7ff146b
Combine fprintf
DamonGuy Dec 22, 2025
092940f
fputs and copyright
DamonGuy Dec 23, 2025
90396f2
fprintf with newline
DamonGuy Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/jdk.accessibility/windows/native/toolscommon/AccessInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ void logString(FILE *logfile, const char *msg, ...) {
va_start(argprt, msg);
vsnprintf(tmpbuf, sizeof(tmpbuf), msg, argprt);

fprintf(logfile, tmpbuf);
fprintf(logfile, "\n");
fprintf(logfile, "%s\n", tmpbuf);
Copy link
Member

@aivanov-jdk aivanov-jdk Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use fputs and avoid all the format string logic and ambiguity altogether?

Alternatively, use vfprintf directly instead of first formatting the arguments into a temporary buffer with vsnprintf and then sending the result to the output.

Copy link
Contributor

@prrace prrace Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar pattern is used elsewhere in this file. And I don't want this fix to become a reworking of this code, because that isn't a goal here.

Copy link
Contributor Author

@DamonGuy DamonGuy Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading about fputs, I think this is best. Like you mentioned, no ambiguity since it does not use specifiers. Updated.

Copy link
Member

@aivanov-jdk aivanov-jdk Dec 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar pattern is used elsewhere in this file. And I don't want this fix to become a reworking of this code, because that isn't a goal here.

Indeed, it is.

I agree it's better to keep the code consistent.

At the same time, I think it's worth submitting a bug to simplify usages like that, fputs works perfectly for strings that don't require formatting.

Copy link
Contributor

@prrace prrace Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Damon already made the change and its just one line I'm fine to keep it but not go looking for more.

fflush(logfile);
}

Expand Down