8367949: JFR: MethodTrace double-counts methods that catch their own exceptions

[egahlin]

Could I have a review of a PR that changes how the instrumentation of the MethodTrace and MethodTiming events is implemented, so they handle exceptions in a better way?

For constructors, the current implementation is still used in certain corner cases. A proper implementation would require data-flow analysis, but for all practical purposes this code should work fine.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367949: JFR: MethodTrace double-counts methods that catch their own exceptions (Bug - P3)

Reviewers without OpenJDK IDs

• @khanbilal732 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28947/head:pull/28947
$ git checkout pull/28947

Update a local copy of the PR:
$ git checkout pull/28947
$ git pull https://git.openjdk.org/jdk.git pull/28947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28947

View PR using the GUI difftool:
$ git pr show -t 28947

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28947.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6b2473dc)

[JnRouvignac]

Suggested change

	if (modifyClassElement(classModel,classBuilder, ce)) {
	if (modifyClassElement(classModel, classBuilder, ce)) {

[JnRouvignac]

Suggested change

	return modifyMethod(classModel,classBuilder, mm, tm);
	return modifyMethod(classModel, classBuilder, mm, tm);