Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 22, 2025

Please review the application of the @Serial annotation (JDK-8202385) to types in the java.security.jgss module to enable stricter compile-time checking of serialization-related declarations.

Example of a similar change #24891.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370368: Apply java.io.Serial annotations in java.security.jgss (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27925/head:pull/27925
$ git checkout pull/27925

Update a local copy of the PR:
$ git checkout pull/27925
$ git pull https://git.openjdk.org/jdk.git pull/27925/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27925

View PR using the GUI difftool:
$ git pr show -t 27925

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27925.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 22, 2025

@mrserb The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review October 22, 2025 06:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2025
@java.io.Serial
static final long serialVersionUID = 0L;
private static final long serialVersionUID = 0L;
private final int errorCode;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that private will not affect the behavior of the code.

@mlbridge
Copy link

mlbridge bot commented Oct 22, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security [email protected]

Development

Successfully merging this pull request may close these issues.

1 participant