8370248: AOTMapLogger should check if pointer is in AOTMetaspace

[iklam]

This fixes a recent bug in AOTMapLogger that's exposed in macOS 26 testing.

When running the JVM with a valid AOT cache (or AOT cache) with the flag -Xlog:aot+map=debug, we use AOTMapLogger::RuntimeGatherArchivedMetaspaceObjs to discover all metaspace objects that are contained in the AOT cache.

However, this code is executed after some of the AOT-cached classes are linked. As a result, RuntimeGatherArchivedMetaspaceObjs::do_unique_ref() could see instances of AdapterHandlerEntry which are dynamically allocated and their addresses are outside of the AOT cache.

In all platforms except macOS 26, the AdapterHandlerEntry pointers are all above the address range of the AOT cache, and they are filtered out by subsequent code in AOTMapLogger. However, on macOS 26, the AdapterHandlerEntry pointers are below the AOT cache, and they caused this assert to fail:

jdk/src/hotspot/share/cds/aotMapLogger.cpp

Lines 240 to 242 in 9a88d7f

	if (p < rw_base) {
	// We are printing the dynamic archive but found an object in the static archive
	precond(!mapinfo->is_static());

The fix is simple: filter out all pointers that are outside of the address range of the AOT cache in do_unique_ref().

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370248: AOTMapLogger should check if pointer is in AOTMetaspace (Bug - P2)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Andrew Dinn (@adinn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27918/head:pull/27918
$ git checkout pull/27918

Update a local copy of the PR:
$ git checkout pull/27918
$ git pull https://git.openjdk.org/jdk.git pull/27918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27918

View PR using the GUI difftool:
$ git pr show -t 27918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27918.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370248: AOTMapLogger should check if pointer is in AOTMetaspace

Reviewed-by: kvn, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 9a88d7f: 8369211: AArch64: Devirtualize class RelocActions
• b77b910: 8369349: Add missing CPE headers
• 0529a58: 8370326: Parallel: Remove unused ParCompactionManager::push
• ... and 10 more: https://git.openjdk.org/jdk/compare/634746a0f167da50c2aef010756f607a436696e9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e42b3833)

[vnkozlov]

Good.

[adinn]

Looks good.

[iklam]

Thanks @vnkozlov @adinn for the review
/integrate

[openjdk]

Going to push as commit 70e7861.
Since your change was applied there have been 24 commits pushed to the master branch:

• 94c0611: 8370122: jpackage test lib improvements
• ed153ee: 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data
• cac2519: 8356578: Test --mac-entitlements
• ... and 21 more: https://git.openjdk.org/jdk/compare/634746a0f167da50c2aef010756f607a436696e9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 70e7861.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.