-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370227: Migrate micros-javac benchmarks from jmh-jdk-microbenchmarks #27917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
@cl4es This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
…s on updated compiler plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
To improve and consolidate workflow this PR proposes moving micros-javac from https://github.com/openjdk/jmh-jdk-microbenchmarks into the main OpenJDK tree.
Most of jmh-jdk-microbenchmarks was effectively migrated in-tree as part of https://openjdk.org/jeps/230
These javac benchmarks, however, were added after migration as a stop-gap solution: they rely on an antrun task to download a configurable set of JDK source files deemed problematic to integrate with the JDK build and the resulting benchmark jar is quite bulky (~52M), so unconditionally piling that on the test image built on every change seems unwise.
Proposal:
test/benchmarks/micros-javac
make test
or equivalent ofmake micros-javac
for now. Instead users of these benchmarks are encouraged to build the benchmarks by runningmvn install
in themicros-javac
folder, similar to what you would do today in the jmh-jdk-microbenchmarks project.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27917/head:pull/27917
$ git checkout pull/27917
Update a local copy of the PR:
$ git checkout pull/27917
$ git pull https://git.openjdk.org/jdk.git pull/27917/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27917
View PR using the GUI difftool:
$ git pr show -t 27917
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27917.diff
Using Webrev
Link to Webrev Comment