Skip to content

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Oct 21, 2025

To improve and consolidate workflow this PR proposes moving micros-javac from https://github.com/openjdk/jmh-jdk-microbenchmarks into the main OpenJDK tree.

Most of jmh-jdk-microbenchmarks was effectively migrated in-tree as part of https://openjdk.org/jeps/230
These javac benchmarks, however, were added after migration as a stop-gap solution: they rely on an antrun task to download a configurable set of JDK source files deemed problematic to integrate with the JDK build and the resulting benchmark jar is quite bulky (~52M), so unconditionally piling that on the test image built on every change seems unwise.

Proposal:

  • The JMH benchmarks are moved over as-is along with a flattened and updated maven pom.xml into a new non-jtreg test root, test/benchmarks/micros-javac
  • Any integration with the JDK build is deferred to a future enhancement. I.e., no integration with make test or equivalent of make micros-javac for now. Instead users of these benchmarks are encouraged to build the benchmarks by running mvn install in the micros-javac folder, similar to what you would do today in the jmh-jdk-microbenchmarks project.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370227: Migrate micros-javac benchmarks from jmh-jdk-microbenchmarks (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27917/head:pull/27917
$ git checkout pull/27917

Update a local copy of the PR:
$ git checkout pull/27917
$ git pull https://git.openjdk.org/jdk.git pull/27917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27917

View PR using the GUI difftool:
$ git pr show -t 27917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27917.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2025

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370227: Migrate micros-javac benchmarks from jmh-jdk-microbenchmarks

Reviewed-by: asotona, erikj, ecaspole

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@cl4es The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2025

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 21, 2025
Copy link

@ericcaspole ericcaspole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants