8370237: AssertionError in Annotate.fromAnnotations with -Xdoclint and type annotations

[cushon]

Hi, please consider this fix for a crash with -Xdoclint and type annotations. It is a generalization of a previous fix for JDK-8266082.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370237: AssertionError in Annotate.fromAnnotations with -Xdoclint and type annotations (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27901/head:pull/27901
$ git checkout pull/27901

Update a local copy of the PR:
$ git checkout pull/27901
$ git pull https://git.openjdk.org/jdk.git pull/27901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27901

View PR using the GUI difftool:
$ git pr show -t 27901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27901.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@cushon The following labels will be automatically applied to this pull request:

• compiler
• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a99313bc)
• 00: Full (2d935b43)

[cushon]

The CI failures are because this improves the errors reported for test/langtools/tools/doclint/CrashInAnnotateTest.java, I pushed a fix