fix(build): probe CUDA toolkit layouts in a shared openinfer-build crate#343
Open
FeathBow wants to merge 1 commit into
Open
fix(build): probe CUDA toolkit layouts in a shared openinfer-build crate#343FeathBow wants to merge 1 commit into
FeathBow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #342
CUDA toolkit discovery was duplicated across build scripts, each assuming the classic
/usr/local/cudalayout (lib64/for libs,include/for headers). Two real layouts break it: conda/micromamba (libs inlib/, headers intargets/<arch>-linux/include/) and the NVIDIA HPC SDK (cuBLAS in amath_libs/<ver>sibling tree). This PR concentrates discovery in a sharedopeninfer-buildcrate:find_packageprobes several check files per root, andcuda_libsprobeslib64/lib/targets/<arch>/libplus themath_libssibling, emitting only dirs that exist. The evidenced sites (openinfer-kernels, cuda-sys, cudart-sys) migrate to it; gdrapi-sys/libibverbs-sys keep their behavior through the same helper.Before
LIBRARY_PATHexport.cargo test --workspacedown with them.Error logs
After
LIBRARY_PATHunset; the workaround is deleted.Verification logs
Type of Change
Checklist
docs/conventions/coding-style.md).CLAUDE.md).