test(qwen3): cover TP=2 in the hf golden gate#322
Merged
xiaguan merged 1 commit intoJun 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #245
Adds TP=2 coverage to the Qwen3-4B HF golden gate. The gate previously only ever ran
device_ordinals: vec![0]. The eager replay suite (bs=1 sequential with the determinism rerun, batched isolation, both prefix-cached replays) is extracted intorun_eager_suite(golden, model_path, devices, label)and rerun under TP=2 with the same golden and tolerances. No new golden files. The pass lives in the existing#[test], so it runs in the normal local test flow on any machine with >= 2 GPUs and skips automatically below that. TP=8 is the follow-on already named in the issue.Test Env
skipping hf_golden_gate TP=2 pass: 1 CUDA device(s) visible, need 2.Full gate output on the dual-GH200 (single-GPU + TP=2, one process)
Type of Change
Checklist
docs/conventions/coding-style.md).CLAUDE.md).