Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add session transcript for browser api #374

Merged
merged 33 commits into from
Jan 15, 2025
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
dfa6ef4
feat: add session transcript for browser api
awoie Dec 19, 2024
84a2f63
Merge branch 'main' into awoie/add-session-transcript
awoie Dec 19, 2024
9969140
Applied Tim's suggestion
awoie Dec 19, 2024
29d60e6
Applied Tim's suggestion
awoie Dec 19, 2024
2277445
Applied Tim's suggestion
awoie Dec 19, 2024
072c38a
Applied Tim's suggestion
awoie Dec 19, 2024
1286f8c
fix: added internal anchor
awoie Dec 19, 2024
62fbaa0
Applied Kristina's suggestion with different wording
awoie Dec 19, 2024
26b7dbe
Applied Joseph's suggestion
awoie Dec 20, 2024
4e402c9
Applied Tim's editorial suggestion
awoie Jan 7, 2025
9b2501c
Applied Christian's editorial suggestion
awoie Jan 7, 2025
9625e87
fix: add doc history
awoie Jan 7, 2025
6cc9039
Applied Paul's editorial suggestion
awoie Jan 8, 2025
4d037df
Applied Paul's editorial suggestion
awoie Jan 8, 2025
5b2f9ea
fix: replaced integrity hash with just hash
awoie Jan 8, 2025
16785ee
fix: added 'cryptographic' where 'hash' is used
awoie Jan 8, 2025
cbcc8d9
fix: adjusted language to make it more clear how OID4VPDCAPIHandoverI…
awoie Jan 8, 2025
d8f87ae
fix: removed SRI dependency since crypto agility since SessionTranscr…
awoie Jan 9, 2025
2b0fee5
fix: updated info hash to be a bstr
awoie Jan 9, 2025
f350f5a
fix: modified according to resolution taken by dcp call jan 9th
awoie Jan 9, 2025
bce5c46
fix: referring to annex for origin definition
awoie Jan 9, 2025
04dd76f
fix: added -7 reference to non DC API invocation mechanism
awoie Jan 10, 2025
d426c43
fix: fixed reference notation
awoie Jan 10, 2025
6dcec68
Applied Torsten's suggestion
awoie Jan 10, 2025
1e2e341
Applied Kristina's suggestion
awoie Jan 14, 2025
2cd0c3b
Applied Kristina's suggestion
awoie Jan 14, 2025
25c2588
Applied Kristina's suggestion
awoie Jan 14, 2025
2d4a76d
ed: changed - to * in list
awoie Jan 14, 2025
88e6cd9
ed: inserted empty lines for readability
awoie Jan 14, 2025
2ed5872
fix: changed OID4VP into OpenID4VP
awoie Jan 14, 2025
cdde599
Applied Christian's suggestion
awoie Jan 14, 2025
8e0259b
ed: fixed custom URI scheme for mdocs
awoie Jan 14, 2025
2c9f80e
Merge branch 'main' into awoie/add-session-transcript
Sakurann Jan 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: added 'cryptographic' where 'hash' is used
awoie committed Jan 8, 2025
commit 16785eeb00bd03d704bae4bd5cb81e0d91cffcac
4 changes: 2 additions & 2 deletions openid-4-verifiable-presentations-1_0.md
Original file line number Diff line number Diff line change
@@ -2287,7 +2287,7 @@ If the presentation request is invoked using the Digital Credentials API, the `S
```cddl
OID4VPDCAPIHandover = [
"OID4VPDCAPIHandover", ; A fixed identifier for this handover type
OID4VPDCAPIHandoverInfoHash ; Hash of OID4VPDCAPIHandoverInfo
OID4VPDCAPIHandoverInfoHash ; A cryptographic hash of OID4VPDCAPIHandoverInfo
]
OID4VPDCAPIHandoverInfoHash = tstr ; UTF-8 encoded string for the hash of OID4VPDCAPIHandoverInfo
OID4VPDCAPIHandoverInfo = [
@@ -2303,7 +2303,7 @@ nonce = tstr ; UTF-8 encoded string
The `OID4VPDCAPIHandover` structure has the following elements:

- The first element MUST be the fixed UTF-8 encoded string `"OID4VPDCAPIHandover"`. This serves as a unique identifier for the handover structure to prevent misinterpretation or confusion.
- The second element MUST be the `OID4VPDCAPIHandoverInfoHash` encoded as a UTF-8 string representing the hash of the `OID4VPDCAPIHandoverInfo` CBOR array.
- The second element MUST be the `OID4VPDCAPIHandoverInfoHash` encoded as a UTF-8 string representing the cryptographic hash of the `OID4VPDCAPIHandoverInfo` CBOR array.
- The value of `OID4VPDCAPIHandoverInfoHash` MUST comply with the W3C Subresource integrity format as defined in [!W3C.SRI] (see below), e.g., `sha256-H8BRh8j48O9oYatfu5AZzq6A9RINhZO5H16dQZngK7T62em8MUt1FLm52t+eX6xO`.
- The `OID4VPDCAPIHandoverInfo` has the following elements:
- The first element MUST be the UTF-8 encoded string representing the `origin` of the Verifier to protect against MITM attacks. The value for `origin` MUST be the one the web platform or app platform asserted the request was made by.