-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require typ in request objects #355
base: main
Are you sure you want to change the base?
Conversation
dc190ff
to
d263e13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a text from RFC9101, which is much more relaxed than the current PR text. I understand that mandating oauth-authz-req+jwt
helps with the interop, but I think we need to discuss implications on the implementations. For example, I am aware of the implementations that use jwt
as a typ
value.
Another way to prevent cross-JWT confusion is to use explicit typing, as described in Section 3.11 of [RFC8725]. One would explicitly type a Request Object by including a typ Header Parameter with the value oauth-authz-req+jwt (which is registered in Section 9.4.1). Note, however, that requiring explicitly typed Request Objects at existing authorization servers will break most existing deployments, as existing clients are already commonly using untyped Request Objects, especially with OpenID Connect [OpenID.Core]. However, requiring explicit typing would be a good idea for new OAuth deployment profiles where compatibility with existing deployments is not a consideration
That text in RFC9101 was there to not breaking existing OpenID Connect implementations (from what I remember the OAuth WG weren't keen to allow that exception) - as I mentioned on the issue no one can use an existing OpenID Connect implementation to request credentials, and we already have other breaking changes happening (E.g. around DCQL) there doesn't seem to be any large issue with following the JWT BCP and doing explicit required typing, and hence requiring implementations to update. |
Co-authored-by: Paul Bastian <[email protected]>
closes #268