Putu Arka Adiana | Register for OpenGuild FRAME Challenges #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look great, can you create pow on Discord so we can give you your reward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the missing functionality in both governance.rs and staking.rs modules. For governance.rs, I added proper initialization for the GovernancePallet struct and implemented core functionality for proposal management including creating proposals, casting votes, retrieving information, and finalizing proposals. In staking.rs, I implemented a balance management system with proper error handling that correctly manages free and staked balances, performs safety checks, and handles edge cases like insufficient balances. I added annotations to suppress compiler warnings for unused imports and dead code. Both modules now pass all test cases, confirming that the implementation satisfies the expected behavior while maintaining the original design and following Rust best practices for error handling, state management, and ownership rules.