Skip to content

Muhammad Ramadhani | Register for OpenGuild FRAME Challenges #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dante4rt
Copy link

@dante4rt dante4rt commented Mar 13, 2025

This pull request includes significant updates to the governance and staking modules, as well as a minor change to the README file. The main focus is on enhancing the governance system and completing the implementation of staking functionalities.

Enhancements to governance module:

  • src/governance.rs: Added SystemConfig to the GovernanceConfig trait to include system-level configurations.
  • src/governance.rs: Modified the Proposal struct to include a creator field and derive PartialEq for the ProposalStatus enum.
  • src/governance.rs: Completed the implementation of methods in GovernancePallet, including create_proposal, vote, get_proposal, finalize_proposal, and a new method get_proposal_details. [1] [2]
  • src/governance.rs: Added tests to verify the new get_proposal_details method.

Enhancements to staking module:

  • src/staking.rs: Updated the StakingConfig trait to require PartialOrd for the Balance type.
  • src/staking.rs: Completed the implementation of methods in StakingPallet, including new, set_balance, stake, unstake, get_free_balance, and get_staked_balance.

Minor update to README:

  • README.md: Added a new participant to the registration table.

@NTP-996
Copy link
Contributor

NTP-996 commented Mar 30, 2025

look great, can you create pow on Discord so we can give you your reward?

@dante4rt
Copy link
Author

dante4rt commented Apr 3, 2025

look great, can you create pow on Discord so we can give you your reward?

PoW here:
https://discord.com/channels/1170911030789029898/1357322018852307074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants