Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace redirect url pattern with route key pattern #398

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+138 −100
Open

feat: replace redirect url pattern with route key pattern #398

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
13d8848
feat: replace redirect url pattern with route key pattern
zhongliang02 Jan 15, 2025
c123713
chore: rename AllRoutes to ALL_ROUTES
zhongliang02 Jan 20, 2025
097298d
fix: put PublicPageWrapper router calls in a useEffect
zhongliang02 Jan 20, 2025
035ac17
fix: sgidLoginButton to use router.push instead of window.location
zhongliang02 Jan 20, 2025
bd0228d
feat: retain redirect url pattern but validate urls against whitelist
zhongliang02 Jan 20, 2025
d97cb95
chore: npm format:fix
zhongliang02 Jan 20, 2025
8ed0be6
fix: callbackUrlSchema should fallback gracefully instead of throwing
zhongliang02 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: sgidLoginButton to use router.push instead of window.location
@zhongliang02
zhongliang02 committed Jan 20, 2025
commit 035ac17e69e9d7d44b141295cf339239b4508946
2 changes: 1 addition & 1 deletion src/features/sign-in/components/SgidLogin/SgidLoginButton.tsx
View file
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ export const SgidLoginButton = (): JSX.Element | null => {
const router = useRouter()
const sgidLoginMutation = trpc.auth.sgid.login.useMutation({
onSuccess: async ({ redirectUrl }) => {
window.location.href = redirectUrl
await router.push(redirectUrl)
},
})