fix: fe crash due to referencing server env var NODE_ENV

[zhongliang02]

Context

FE was crashing due to referencing server env var NODE_ENV in src/pages/_app.tsx

This issue comes from PR #383 where we replaced NODE_ENV references.

Root cause

1. Failure to differentiate between env.NODE_ENV and process.env.NODE_ENV:

• env.NODE_ENV is evaluated at runtime
• process.env.NODE_ENV is baked during build time.

2. Human factors:

• Lack of manual testing in previous PR (feat: make node_env checks safe by default #383)
• Merging the PR before the CI pipeline completed its checks

Approach & Testing

• Corrected all NODE_ENV references to the appropriate types (runtime vs build time)
• Tested locally with npm run dev and npm run build && npm run start, works perfectly.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
starter-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 5:05am

[datadog-opengovsg]

Datadog Report

Branch report: 01-03-fix_fe_crash_due_to_referencing_server_env
Commit report: b4ca68a
Test service: starter-kit

✅ 0 Failed, 11 Passed, 0 Skipped, 10.23s Total Time
➡️ Test Sessions change in coverage: 1 no change