Just improve your old module and render it wonderfully nicer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-kl1
requested changes
Nov 9, 2024
| 'jquery/ui', | ||
| 'domReady!' | ||
| ], function($) { | ||
| document.addEventListener('DOMContentLoaded', function() { | ||
| "use strict"; |
There was a problem hiding this comment.
est-ce que tu peux déplacer le use strict au dessus de document stpl ?
| /** @var ViewModelRegistry $viewModels */ | ||
|
|
||
| /** @var Snowflake $snowflake */ | ||
| $snowflake = $viewModels->require(Snowflake::class) |
There was a problem hiding this comment.
tu peux revert cette ligne comme ça on est agnostique luma/hyva
Siln0z
force-pushed
the
feature/snowflake_ultimate_version_Hyva_compat
branch
from
411e670 to
d2a52cf
Compare
thomas-kl1
reviewed
Nov 11, 2024
Comment on lines
-22
to
+25
| <field id="icon" translate="label comment" type="text" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1"> | ||
| <label>Icon</label> | ||
| <comment><![CDATA[Icon to display as a snowflake ❄️, get <a href="https://emojipedia.org/" target="_blank">more emoji</a>.]]></comment> | ||
| <backend_model>Opengento\Snowflake\Model\Config\Backend\EmojiConverter</backend_model> | ||
| <field id="season" translate="label" type="select" sortOrder="15" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1"> | ||
| <label>Season/Festival</label> | ||
| <source_model>Opengento\Snowflake\Model\Config\Source\Season</source_model> | ||
| <comment><![CDATA[Choose a season or festival for the icons.]]></comment> |
There was a problem hiding this comment.
Est-ce que tu peux t'arranger pour conserver les deux champs et ajouter un champ toggle pour utiliser soit les presets, soit un icon custom ?
|
|
||
| function letSnow() { | ||
| let snowMax = <?= $viewModel->getSnowflakeQty() ?>; | ||
| let snowColor = ["#DDD", "#BBB", "#AAA", "#EEE", "#CCC"]; |
There was a problem hiding this comment.
La couleur permettait d'améliorer l'impression de profondeur sur la "neige", est-ce que tu peux conserver cette ligne quitte à la commenter pour qu'on voit comment l'intégrer plus tard avec les presets de saisons ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎃 👻 🦇 ❄️ 🎅 🎄 🌷 🐣 ☀️ 🌞 🏖️ 🍉 🍂 🍁 🎆 🇫🇷 🥳 🎇 🎉 🥂 🐰 🥚 💖 🌹 💕 ⚒️ 🌻 🛠️ 🎵 🎸 🎤 ☃️ 🌨️ 🌸 🦋 🍦 🏄 🕸️ 🤶 🎭 🎊 🤹 ☘️ 🍺 🇮🇪 🕎 ✨ 🥯 🌙 🕌 🕋 🪔 🌟 🐉 🏮 🧧 💐 👩👧👦 👔 🍻 🎣 🦃 🥧 🎁 🧨 🌭 🕺 🎶 🍹 🍾