Skip to content

Remove unused feeSponsorshipId from CreateEmbeddedWalletOptions - #353

Merged
jamalavedra merged 1 commit into
mainfrom
fix/remove-fee-sponsorship-id-option
Sep 26, 2026
Merged

jamalavedra merged 1 commit into
mainfrom
fix/remove-fee-sponsorship-id-option

Conversation

@jamalavedra

Copy link
Copy Markdown

CreateEmbeddedWalletOptions declared feeSponsorshipId?: string, but nothing in the SDK read it. create() in createEmbeddedWalletHook.ts hands the options only to buildAccountRequest (which reads accountType and chainId) and to the recovery step. Gas sponsorship is resolved on the provider, per chain, from walletConfig.ethereum.ethereumFeeSponsorshipId via resolveEthereumFeeSponsorship in CoreOpenfortProvider.tsx.

This PR:

  • removes the field from CreateEmbeddedWalletOptions in packages/openfort-react/src/shared/types.ts. ImportEmbeddedWalletOptions extends that type, so the field goes from there too.
  • drops "gas sponsorship" from the type's doc comment.
  • adds a patch changeset.

Runtime behaviour does not change. Code that passes feeSponsorshipId in an object literal now gets a type error; the fix is to delete the option, which never did anything. The changeset is patch for that reason. Change it to minor if you would rather ship type-surface removals that way.

Tested locally: pnpm check, pnpm check:types, pnpm test:types and pnpm test:unit (890 tests) all pass.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
playground Ready Ready Preview Sep 26, 2026 4:59pm UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@openfort/react@353

commit: 6886166

@jamalavedra
jamalavedra merged commit 3864c47 into main Sep 26, 2026
19 checks passed
@jamalavedra
jamalavedra deleted the fix/remove-fee-sponsorship-id-option branch September 26, 2026 18:25
@github-actions github-actions Bot mentioned this pull request Sep 26, 2026

This branch was successfully deployed

1 active deployment
Preview — 68861666 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant