Skip to content

5758 - Navigation: Data errors - Add LinksService.enqueueAllLinksValidation - #6167

Merged
mergify[bot] merged 3 commits into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-102
Jul 27, 2026
Merged

5758 - Navigation: Data errors - Add LinksService.enqueueAllLinksValidation#6167
mergify[bot] merged 3 commits into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-102

Conversation

@yaguzmang

@yaguzmang yaguzmang commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

We have LinksService:

  • enqueueDescriptionLinksValidation
  • enqueueNationalDataPointLinksValidation

Those enqueue jobs and make sure there is a worker to process it.

So, for consistency, I am adding enqueueAllLinksValidation which does the same.

@yaguzmang
yaguzmang marked this pull request as ready for review July 24, 2026 18:37
Comment thread src/server/service/links/index.ts Outdated
import { enqueueDescriptionLinksValidation } from 'server/service/links/enqueueDescriptionLinksValidation'
import { enqueueNationalDataPointLinksValidation } from 'server/service/links/enqueueNationalDataPointLinksValidation'
import { verifyLinks } from 'server/service/links/verifyLinks'
import { scheduleVerifyAllLinks } from 'server/worker/tasks/verifyLinks/visitCycleLinks/scheduleVerifyAllLinks'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to rename this as well .
The exported method should have the same name

@yaguzmang
yaguzmang requested a review from minotogna July 27, 2026 13:28
@mergify mergify Bot added the queued label Jul 27, 2026
@mergify

mergify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-27 14:12 UTC · Rule: default · triggered by rule Automatic merge using squash
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-27 14:12 UTC · at cf0e47943049b3d4b203d455efa20357adf5da41 · squash

This pull request spent 15 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit f695785 into 5758-navigation-data-errors Jul 27, 2026
5 checks passed
@mergify
mergify Bot deleted the 5758-navigation-data-errors-102 branch July 27, 2026 14:12
@mergify mergify Bot removed the queued label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants