Skip to content

5758 - Navigation: Data errors - Rename DescriptionIdentifier to CommentableDescriptionKey#6164

Merged
mergify[bot] merged 1 commit into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-101
Jul 24, 2026
Merged

5758 - Navigation: Data errors - Rename DescriptionIdentifier to CommentableDescriptionKey#6164
mergify[bot] merged 1 commit into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-101

Conversation

@yaguzmang

@yaguzmang yaguzmang commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Addressing from the main PR TODO:
"

  • Revisit DescriptionIdentifier type — maybe use Pick and revisit name.

"

Proposal:

export type CommentableDescriptionKey = Pick<CommentableDescription, 'name' | 'sectionName'>

@yaguzmang
yaguzmang marked this pull request as ready for review July 24, 2026 16:42
@mergify mergify Bot added the queued label Jul 24, 2026
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-24 17:30 UTC · Rule: default · triggered by rule Automatic merge using squash
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-24 17:31 UTC · at da49cd442019926f6fe60c9a4a23cb3add325a53 · squash

This pull request spent 15 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit 91a071c into 5758-navigation-data-errors Jul 24, 2026
5 checks passed
@mergify
mergify Bot deleted the 5758-navigation-data-errors-101 branch July 24, 2026 17:31
@mergify mergify Bot removed the queued label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants