5758 - Navigation: Data errors - Rename visitDescriptionLinks & visitNationalDataPointLinks#6163
Merged
mergify[bot] merged 3 commits intoJul 24, 2026
Conversation
yaguzmang
marked this pull request as ready for review
July 24, 2026 14:25
minotogna
approved these changes
Jul 24, 2026
Contributor
Merge Queue Status
This pull request spent 1 minute 15 seconds in the queue, including 9 seconds running CI. Required conditions to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing from the main PR todo:
"
LinkService.validateLinks.visitDescriptionLinks, and what is the difference withtriggerVerifyLinksWorker?"To answer the question: “Why do we call
visitDescriptionLinks, and what is the difference withtriggerVerifyLinksWorker?”:visitDescriptionLinksis now calledLinksService.enqueueDescriptionLinksValidation, which better represents what it does. It doesn’t visit the links directly. It enqueues averifyDescriptionLinksjob.triggerVerifyLinksWorkeris different. It only makes sure a worker process exists to consume the queue (in-process in dev, no-op in e2e where a dedicated container runs, one-off dyno in production).We don’t call
triggerVerifyLinksWorkerdirectly fromenqueueDescriptionLinksValidationbecause the shared producerenqueueVerifyLinksJob(renamed fromaddVerifyLinksJobto align with the renames) already does that after adding the job to the queue.In short:
enqueueDescriptionLinksValidationschedules the validation, whiletriggerVerifyLinksWorkermakes sure there is a worker to process it.