Skip to content

5758 - Navigation: Data errors - Rename visitDescriptionLinks & visitNationalDataPointLinks#6163

Merged
mergify[bot] merged 3 commits into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-100
Jul 24, 2026
Merged

5758 - Navigation: Data errors - Rename visitDescriptionLinks & visitNationalDataPointLinks#6163
mergify[bot] merged 3 commits into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-100

Conversation

@yaguzmang

@yaguzmang yaguzmang commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Addressing from the main PR todo:
"

  • visitDescriptionLinks:
    • Move it to LinkService.validateLinks.
    • Why do we call visitDescriptionLinks, and what is the difference with triggerVerifyLinksWorker?"

To answer the question: “Why do we call visitDescriptionLinks, and what is the difference with triggerVerifyLinksWorker?”:

visitDescriptionLinks is now called LinksService.enqueueDescriptionLinksValidation, which better represents what it does. It doesn’t visit the links directly. It enqueues a verifyDescriptionLinks job.

triggerVerifyLinksWorker is different. It only makes sure a worker process exists to consume the queue (in-process in dev, no-op in e2e where a dedicated container runs, one-off dyno in production).

We don’t call triggerVerifyLinksWorker directly from enqueueDescriptionLinksValidation because the shared producer enqueueVerifyLinksJob (renamed from addVerifyLinksJob to align with the renames) already does that after adding the job to the queue.

In short: enqueueDescriptionLinksValidation schedules the validation, while triggerVerifyLinksWorker makes sure there is a worker to process it.

@yaguzmang
yaguzmang marked this pull request as ready for review July 24, 2026 14:25
@mergify mergify Bot added the queued label Jul 24, 2026
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-24 16:05 UTC · Rule: default · triggered by rule Automatic merge using squash
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-24 16:06 UTC · at a48cffdbcbab58ecf02556ac2e4a017223e2bc2e · squash

This pull request spent 1 minute 15 seconds in the queue, including 9 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit 19f2696 into 5758-navigation-data-errors Jul 24, 2026
5 checks passed
@mergify
mergify Bot deleted the 5758-navigation-data-errors-100 branch July 24, 2026 16:06
@mergify mergify Bot removed the queued label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants