User groups: layout adjustments - #4332
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the “User Groups” area under the Users app module by moving it into a dedicated UserGroups view with a tabbed editor (groups list / assignments kanban / members report), updating routing accordingly, and adjusting layout/scrolling behavior to better fit the available height.
Changes:
- Replaces the legacy
Users/UserGroupsOverviewroute component with the newUserGroupsEditor(tabbed UI) and relocatesUserGroupEditunder the newUserGroupsview hierarchy. - Updates User Groups list/report UI to use the shared
DataGridcomponent (including new row-click support) and adjusts kanban/table layout CSS for internal scrolling. - Updates i18n keys for the new tab labels across supported locales.
Reviewed changes
Copilot reviewed 32 out of 43 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webapp/views/App/views/Users/Users.js | Routes user-groups to the new UserGroupsEditor and updates edit route imports. |
| webapp/views/App/views/Users/UserGroupsOverview/UserGroupsSummary/index.ts | Removes legacy re-export for the old summary component. |
| webapp/views/App/views/Users/UserGroupsOverview/UserGroupsOverview.scss | Removes legacy overview layout styles. |
| webapp/views/App/views/Users/UserGroupsOverview/UserGroupsList/UserGroupsList.tsx | Removes legacy user-groups list (old Table-based implementation). |
| webapp/views/App/views/Users/UserGroupsOverview/UserGroupsList/RowHeader.tsx | Removes legacy list header component. |
| webapp/views/App/views/Users/UserGroupsOverview/UserGroupsList/Row.tsx | Removes legacy list row component. |
| webapp/views/App/views/Users/UserGroupsOverview/index.tsx | Removes the legacy UserGroupsOverview page implementation. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsTable/useUserGroupsTable.ts | Updates internal comment to reflect renamed overview hook precedent. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsTable/UserGroupsTable.tsx | Removes autoHeight to allow the grid to fill/scroll within the tab content area. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsTable/index.ts | Adds index export for the User Groups report table. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/useUserGroupsOverview.ts | Renames the hook/types from “Summary” to “Overview” for the kanban assignments view. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/useUserGroupsKanbanDnd.ts | Updates documentation to match the new “Overview” naming. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/UserGroupsOverview.tsx | Renames the kanban component and wires it to the renamed hook/constants and CSS class. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/UserGroupsOverview.scss | Updates class names and layout rules for better height/scroll behavior. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/UserGroupColumn.tsx | Updates type import and documentation to match renamed overview hook/component. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/UserCard.tsx | Updates type import and documentation to match renamed overview hook/component. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/kanbanConstants.ts | Adds a shared sentinel key for the “Unassigned” kanban column. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsOverview/index.ts | Adds index export for the kanban assignments view. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsList/useUserGroupsList.ts | Adds a new hook to load groups and compute membersCount for the list view. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsList/UserGroupsList.tsx | Adds a new DataGrid-based user groups list with row navigation. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsList/UserGroupsList.scss | Ensures the list grid spans the available width. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsList/index.ts | Adds index export for the groups list tab. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsEditor.tsx | Introduces the new tabbed User Groups editor page (groups/assignments/report). |
| webapp/views/App/views/UserGroups/UserGroupsEditor/UserGroupsEditor.scss | Adds layout rules to disable page-level scroll and enforce internal tab scrolling. |
| webapp/views/App/views/UserGroups/UserGroupsEditor/index.tsx | Adds index export for UserGroupsEditor. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupQualifiersEditor/UserGroupQualifiersEditor.tsx | Adds a dynamic qualifiers editor with inline validation and add/remove controls. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupQualifiersEditor/index.ts | Adds index export for UserGroupQualifiersEditor. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupMembersEditor/useUserGroupMembersEditor.ts | Updates internal comment to reflect renamed overview hook precedent. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupMembersEditor/UserGroupMembersEditor.tsx | Adds a members management panel (list/add/remove) for a saved group. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupMembersEditor/index.ts | Adds index export for UserGroupMembersEditor. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupEdit.tsx | Adds the create/edit form for a single user group, integrating qualifiers and members panels. |
| webapp/views/App/views/UserGroups/UserGroupEdit/UserGroupEdit.scss | Adds layout styling for the group edit form and buttons alignment. |
| webapp/views/App/views/UserGroups/UserGroupEdit/useEditUserGroup.ts | Updates internal comment to reflect renamed overview hook precedent. |
| webapp/views/App/views/UserGroups/UserGroupEdit/index.tsx | Adds index export for UserGroupEdit. |
| webapp/views/App/views/UserGroups/index.js | Exposes UserGroupsEditor via the UserGroups view entry point. |
| webapp/components/Tabs/Tabs.js | Adds controlled-mode selection and full-width support for tab layouts. |
| webapp/components/DataGrid/DataGrid.tsx | Adds onRowClick passthrough to support navigable grids. |
| core/i18n/resources/ru/usersView.js | Updates user-group strings to use new tab label keys. |
| core/i18n/resources/pt/usersView.js | Updates user-group strings to use new tab label keys. |
| core/i18n/resources/mn/usersView.js | Updates user-group strings to use new tab label keys. |
| core/i18n/resources/fr/usersView.js | Updates user-group strings to use new tab label keys. |
| core/i18n/resources/es/usersView.js | Updates user-group strings to use new tab label keys. |
| core/i18n/resources/en/usersView.js | Updates user-group strings to use new tab label keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.