marking node defs without cycles as deleted

server/modules/nodeDef/manager/nodeDefManager.js

@@ -76,6 +76,10 @@ const _onAncestorCyclesUpdate = async ({ survey, nodeDefAncestor, cycles, cycles
   // perform updates in batch
   await client.batch(batchUpdates)
 
+  // a descendant left with no cycles is a dangling node def (invisible in every cycle, but still
+  // occupying its name); soft-delete it instead of leaving it as a live orphan
+  await NodeDefRepository.markNodeDefsWithoutCyclesDeleted(surveyId, client)
+
   return nodeDefsUpdated
 }
 

server/modules/survey/service/publish/jobs/nodeDefsValidationJob.js

@@ -38,6 +38,10 @@ export default class NodeDefsValidationJob extends Job {
     this.setContext({ surveyPublishedPrevious })
 
     await NodeDefManager.deleteOrphaneNodeDefs(surveyId, tx)
+    // self-heal node defs left with an empty cycles array by past bugs (e.g. narrowing an
+    // ancestor entity's cycles), which would otherwise remain invisible ghosts blocking publish
+    // with false duplicate-name errors
+    await NodeDefManager.markNodeDefsWithoutCyclesDeleted(surveyId, tx)
 
     const surveySummary = await SurveyManager.fetchSurveyById({ surveyId, draft: true }, tx)
     const cycleKeys = R.pipe(Survey.getSurveyInfo, Survey.getCycleKeys)(surveySummary)