records import: add missing nodes

server/modules/mobile/service/arenaMobileDataImport/jobs/recordsImportJob.js

@@ -1,4 +1,4 @@
-import { Dates, Objects, Records, Surveys } from '@openforis/arena-core'
+import { Dates, Objects, RecordFixer, Records, Surveys } from '@openforis/arena-core'
 
 import { ConflictResolutionStrategy } from '@common/dataImport'
 
@@ -25,27 +25,6 @@ const resultKeys = {
 const categoryItemProvider = CategoryItemProviderDefault
 const taxonProvider = TaxonProviderDefault
 
-const checkNodeIsValid = ({ nodes, node, nodeDef }) => {
-  if (!nodeDef) {
-    return { valid: false, error: 'refers a missing node definition' }
-  }
-  const parentUuid = Node.getParentUuid(node)
-  if ((!parentUuid && !NodeDef.isRoot(nodeDef)) || (parentUuid && !nodes[parentUuid])) {
-    return { valid: false, error: `has missing or invalid parent_uuid` }
-  }
-  if (NodeDef.isMultipleAttribute(nodeDef) && Node.isValueBlank(node)) {
-    return { valid: false, error: `is multiple and has an empty value` }
-  }
-  const nodeHierarchy = Node.getHierarchy(node)
-  if (
-    nodeHierarchy.length !== NodeDef.getMetaHierarchy(nodeDef)?.length ||
-    nodeHierarchy.some((ancestorUuid) => !nodes[ancestorUuid])
-  ) {
-    return { valid: false, error: `has an invalid meta hierarchy` }
-  }
-  return { valid: true }
-}
-
 const getRecordFormattedKeyValues = ({ survey, record }) => {
   const rootDef = Surveys.getNodeDefRoot({ survey })
   const recordRootEntity = Records.getRoot(record)
@@ -117,18 +96,20 @@ export default class RecordsImportJob extends DataImportBaseJob {
   trackFileUuids({ nodes }) {
     // keep track of file uuids found in record attribute values
     const { survey } = this.context
-    Object.values(nodes).forEach((node) => {
+    for (const node of Object.values(nodes)) {
       const nodeDef = Survey.getNodeDefByUuid(Node.getNodeDefUuid(node))(survey)
       if (NodeDef.isFile(nodeDef)) {
         this.trackFileUuid({ node })
       }
-    })
+    }
   }
 
   async cleanupCurrentRecord() {
     const { context, currentRecord: record, user, tx } = this
     const { survey } = context
 
+    const sideEffect = true // do side effect to avoid creating new objects and use less memory
+
     const recordUuid = Record.getUuid(record)
     // check owner uuid: if user not defined, use the job user as owner
     const ownerUuidSource = Record.getOwnerUuid(record)
@@ -137,25 +118,9 @@ export default class RecordsImportJob extends DataImportBaseJob {
 
     // remove invalid nodes and build index from scratch
     delete record['_nodesIndex']
-    const nodes = Record.getNodes(record)
-
-    for (const [nodeUuid, node] of Object.entries(nodes)) {
-      const nodeDefUuid = Node.getNodeDefUuid(node)
-      const nodeDef = Survey.getNodeDefByUuid(nodeDefUuid)(survey)
-      const { valid, error } = checkNodeIsValid({ nodes, node, nodeDef })
-      if (valid) {
-        // ensure recordUuid is set in node
-        node[Node.keys.recordUuid] = recordUuid
-        Node.removeFlags({ sideEffect: true })(node)
-      } else {
-        const messagePrefix = `record ${Record.getUuid(record)}: node with uuid ${Node.getUuid(node)} and node def ${NodeDef.getName(nodeDef)} (uuid ${nodeDefUuid})`
-        const messageSuffix = `: skipping it`
-        this.logWarn(`${messagePrefix} ${error} ${messageSuffix}`)
-        delete nodes[nodeUuid]
-      }
-    }
-    // assoc nodes and build index from scratch
-    this.currentRecord = Record.assocNodes({ nodes, sideEffect: true })(record)
+
+    // fix record (e.g. insert missing nodes, remove status flags)
+    RecordFixer.fixRecord({ survey, record: this.currentRecord, sideEffect })
   }
 
   findExistingRecordSummaryWithSameKeys() {