use latest arena-core (UserGroup type)#162
Merged
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates Arena Server to use the latest @openforis/arena-core dependency and adopts the UserGroup type (and related props) from arena-core instead of maintaining a duplicated local definition.
Changes:
- Bump
@openforis/arena-corefrom^1.3.8to^1.3.10(and update lockfile accordingly). - Replace local
UserGroup/UserGroupPropstype usage with@openforis/arena-coreexports across service, API, and repository layers. - Remove the local
src/repository/userGroup/types.tstype definitions and stop exporting them from repository barrels.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates resolved @openforis/arena-core version to 1.3.10. |
| package.json | Bumps @openforis/arena-core dependency to ^1.3.10. |
| src/service/userGroup/index.ts | Switches UserGroup/UserGroupProps imports to come from arena-core. |
| src/api/userGroup/common.ts | Switches UserGroup type import to come from arena-core. |
| src/repository/userGroup/update.ts | Uses arena-core UserGroup type for repository function typing. |
| src/repository/userGroup/read.ts | Uses arena-core UserGroup type for repository function typing. |
| src/repository/userGroup/insert.ts | Uses arena-core UserGroup type for repository function typing. |
| src/repository/userGroup/delete.ts | Uses arena-core UserGroup type for repository function typing. |
| src/repository/userGroup/getUserGroupsByUser.ts | Uses arena-core UserGroup type for repository function typing. |
| src/repository/userGroup/index.ts | Removes re-export of local UserGroup types from the userGroup repository barrel. |
| src/repository/userGroup/types.ts | Deletes the local UserGroup type definitions. |
| src/repository/index.ts | Removes re-export of UserGroup types from the top-level repository barrel. |
Comments suppressed due to low confidence (1)
src/repository/userGroup/index.ts:23
- This module no longer re-exports
UserGroup/UserGroupProps, which can break consumers that import these types from../../repository/userGroup.
If the goal is to use the canonical types from @openforis/arena-core, consider re-exporting them from here (type-only) to preserve the existing public surface area.
export type { UserGroupMember } from './members'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.