Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Audit Items model #24

Merged
merged 21 commits into from
Aug 16, 2024
Merged

Feature: Audit Items model #24

merged 21 commits into from
Aug 16, 2024

Conversation

ok200lyndon
Copy link
Collaborator

  • migration, model and factory
  • admin and public end points / controllers
  • tests
  • job and service function for creating
  • admin and public components for viewing

@ok200lyndon ok200lyndon requested a review from ok200paul August 16, 2024 06:48
@@ -17,5 +17,8 @@
"tailwindcss": "^3.2.1",
"vite": "^5.0",
"vue": "^3.4.0"
},
"dependencies": {
"moment": "^2.30.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

momentjs is abandoned, we need to replace with dayjs

Copy link
Collaborator

@ok200paul ok200paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we need to get rid of momentjs, it's abandoned, and get dayjs in its place 👍

@ok200paul ok200paul merged commit 7af83a6 into develop Aug 16, 2024
1 check passed
@ok200paul ok200paul deleted the feature/audit-items branch August 16, 2024 07:57
@ok200paul
Copy link
Collaborator

Merged - thanks! Please delete your local feature branch & do a pull on develop, and merge develop into any other open feature branches you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants