Police migrations #13076
Merged
Police migrations #13076
+522
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added
the
technical changes only
dacook
reviewed
Jan 15, 2025
db/seeds.rb
Outdated
| Spree::Role.where(:name => "user").first_or_create | ||
| Rails.logger.debug "[db:seed] Seeding Roles" | ||
| Spree::Role.where(name: "admin").first_or_create | ||
| Spree::Role.where(name: "user").first_or_create |
There was a problem hiding this comment.
I thought we got rid of "user", or did we just talk about it..
There was a problem hiding this comment.
The user role is unused at the moment. And we talked about getting rid of roles. But it's still there.
dacook
approved these changes
Jan 15, 2025
|
@mkllnk I'll leave it to you to fix the conflict |
mkllnk
force-pushed
the
police-migrations
branch
from
c375c9a to
fcc31ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I noticed in recent pull requests that new migrations were not following our style guide and CI still passed because we are ignoring all database related files.
While we don't want to change old migrations, new migrations should adhere to our current coding standards. The new configuration will enforce that.
One downside is that new migrations will grow old over time and new cops will still apply unless they support the new MigratedSchemaVersion option. So we may want to update the configuration periodically, like once a year, if it becomes inconvenient.
It's not obvious, but the MigratedSchemaVersion option applies only to some cops. Most cops still check all old migrations as well. That's why I added patterns to ignore all migrations before 2025.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates