New variants should inherit tax category in UI #13068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishaldeepak
force-pushed
the
variant-with-tax
branch
from
19ba678 to
87eea13
Compare
sigmundpetersen
changed the title
vishaldeepak
force-pushed
the
variant-with-tax
branch
from
87eea13 to
d381ceb
Compare
vishaldeepak
commented
Jan 10, 2025
| @@ -14,6 +14,7 @@ def prepare_new_variant(product, producer_options) | |||
| # e.g producer_options = [['producer name', id]] | |||
| product.variants.build do |new_variant| | |||
| new_variant.supplier_id = producer_options.first.second if producer_options.one? | |||
| new_variant.tax_category_id = product.variants.first.tax_category_id | |||
There was a problem hiding this comment.
worth adding a check to see if variant exists? Ive noted in UI that a minimum of one variant always exists
There was a problem hiding this comment.
The UI prevents you from deleting a variant if there is only one left, and currently when creating a new product a variant will be created by default. So I think it's fair to assume there will always be one variant.
vishaldeepak
force-pushed
the
variant-with-tax
branch
from
d381ceb to
1586c8e
Compare
rioug
approved these changes
Jan 12, 2025
| @@ -14,6 +14,7 @@ def prepare_new_variant(product, producer_options) | |||
| # e.g producer_options = [['producer name', id]] | |||
| product.variants.build do |new_variant| | |||
| new_variant.supplier_id = producer_options.first.second if producer_options.one? | |||
| new_variant.tax_category_id = product.variants.first.tax_category_id | |||
There was a problem hiding this comment.
The UI prevents you from deleting a variant if there is only one left, and currently when creating a new product a variant will be created by default. So I think it's fair to assume there will always be one variant.
rioug
added
the
user facing changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Creation of a new variant was setting tax category as none. This is problematic for any hub selling taxable products. The fix is on creating a new variant in the UI it should set tax category from the first variant.
What should we test?
After changes it should behave similar to below
opennetwork.mov
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates