Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails standard ApplicationJob for consistency #10283

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 18, 2023

What? Why?

New Rails apps come with this class already, the job generator creates it for every new job and Rubocop requires it as well. Let's make our lives easier and use the same structure as other Rails projects. This class may be handy one day.

This came up in:

What should we test?

  • Specs pass.

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk self-assigned this Jan 18, 2023
@mkllnk mkllnk requested a review from dacook January 18, 2023 04:29
@mkllnk mkllnk marked this pull request as ready for review January 18, 2023 04:29
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve
It's semantically exactly the same as before so I can't imagine the specs would fail, but will wait to make sure before marking ready to go.

New Rails apps come with this class already, the job generator creates
it for every new job and Rubocop requires it as well. Let's make our
lives easier and use the same structure as other Rails projects. This
class may be handy one day.
@dacook
Copy link
Member

dacook commented Jan 19, 2023

Spec flakiness :(

 Ferrum::ProcessTimeoutError:
   Browser did not produce websocket url within 20 seconds, try to increase `:process_timeout`.

@dacook dacook merged commit 4e7c50e into openfoodfoundation:master Jan 19, 2023
@mkllnk mkllnk deleted the application-job branch February 27, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants