Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get the product details from the barcode ( #185) #255

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shradiphylleia
Copy link

What

Screenshot

if the product is present the product details will be fetched
Screenshot 2025-03-15 003243
Screenshot 2025-03-15 003256

Fixes bug(s)

Part of

@shradiphylleia shradiphylleia requested a review from a team as a code owner March 14, 2025 19:24
@shradiphylleia shradiphylleia changed the title get the product details from the barcode ( #185) feat:get the product details from the barcode ( #185) Mar 14, 2025
@shradiphylleia shradiphylleia changed the title feat:get the product details from the barcode ( #185) feat: get the product details from the barcode ( #185) Mar 14, 2025
@areebahmeddd
Copy link
Member

I don't think this is the correct way of implementing a Knowledge Panel.

@shradiphylleia
Copy link
Author

shradiphylleia commented Mar 15, 2025

I don't think this is the correct way of implementing a Knowledge Panel.

thanks for having a look at my pr.
Alex garel mentioned that setting up backend route and creating the web component were being treated independently. mentioning the conversation for reference:
#185 (comment)

@alexgarel
Copy link
Member

@shradiphylleia as noted by @areebahmeddd this does not match the knowledge panels api specification at all.

Also the API should be something like product//knowledge_panels

@shradiphylleia
Copy link
Author

will have a look at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Knowledge Panel compliant route for the Folksonomy Engine list of properties for a given barcode
3 participants