-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate dependency management to Poetry #247
feat: Migrate dependency management to Poetry #247
Conversation
Hey @alexgarel I haven't updated Edit: Trying to fix failing checks. no idea why Postgres isn't setting up properly. Any guidance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@areebahmeddd you have to push the poetry lock file (this is one of the goal of the move, to be sure to reproduce exactly the build).
@CharlesNepote are you ok with it ?
Let me ping you on this by eod, need to update the install.md and iron out the failed run Thanks for taking your time and looking at my PR :) |
Looks good? @alexgarel |
@areebahmeddd can you fix tests ? |
Looking into it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 95.06% 94.66% -0.40%
==========================================
Files 5 5
Lines 324 375 +51
==========================================
+ Hits 308 355 +47
- Misses 16 20 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All runs are passing, apologies for the delay! I’m aware of how my formatter behaves and have noted your comment about avoiding unnecessary changes. I’ve raised an issue to add a CC: @alexgarel |
Signed-off-by: Areeb Ahmed [email protected]
Summary of Changes
Fixes: #154
requirements.txt
withpyproject.toml
andpoetry.lock
pyproject.toml
using PoetryREADME.md
andINSTALL.md
to reflect the new dependency management process