Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate dependency management to Poetry #247

Merged

Conversation

areebahmeddd
Copy link
Member

Signed-off-by: Areeb Ahmed [email protected]

Summary of Changes

Fixes: #154

  • Replaced requirements.txt with pyproject.toml and poetry.lock
  • Added all dependencies to pyproject.toml using Poetry
  • Updated CI configuration to use Poetry for installing dependencies
  • Updated README.md and INSTALL.md to reflect the new dependency management process

@areebahmeddd areebahmeddd requested a review from a team as a code owner March 8, 2025 19:53
@areebahmeddd areebahmeddd requested a review from alexgarel March 8, 2025 19:59
@areebahmeddd
Copy link
Member Author

areebahmeddd commented Mar 8, 2025

Hey @alexgarel

I haven't updated install.md yet, but could you check out the PR I opened to update the docs first?
Thanks!

Edit: Trying to fix failing checks. no idea why Postgres isn't setting up properly. Any guidance?
Maybe I'll need to run it manually and check what's missing when running:
poetry run python db-migration.py

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@areebahmeddd you have to push the poetry lock file (this is one of the goal of the move, to be sure to reproduce exactly the build).

@CharlesNepote are you ok with it ?

@areebahmeddd
Copy link
Member Author

Let me ping you on this by eod, need to update the install.md and iron out the failed run

Thanks for taking your time and looking at my PR :)

@areebahmeddd
Copy link
Member Author

Looks good? @alexgarel

@alexgarel
Copy link
Member

@areebahmeddd can you fix tests ?

@areebahmeddd
Copy link
Member Author

Looking into it

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (b9cda65) to head (5aea9db).
Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   95.06%   94.66%   -0.40%     
==========================================
  Files           5        5              
  Lines         324      375      +51     
==========================================
+ Hits          308      355      +47     
- Misses         16       20       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@areebahmeddd
Copy link
Member Author

All runs are passing, apologies for the delay!

I’m aware of how my formatter behaves and have noted your comment about avoiding unnecessary changes. I’ve raised an issue to add a .pre-commit.yaml file to keep the code clean. (#256)

CC: @alexgarel

@alexgarel alexgarel merged commit 45d881a into openfoodfacts:main Mar 18, 2025
9 checks passed
@areebahmeddd areebahmeddd deleted the feat/issue-154/pip-to-poetry branch March 18, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants