Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored api.py into routes. Fixes #232 #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nasredeenabdulhaleem
Copy link

What

Screenshot

Fixes bug(s)

Part of

@nasredeenabdulhaleem nasredeenabdulhaleem requested a review from a team as a code owner March 4, 2025 14:57
@nasredeenabdulhaleem nasredeenabdulhaleem changed the title Feat: Refactored api.py into routes. Fixes #232 refactor: Refactored api.py into routes. Fixes #232 Mar 4, 2025
@nasredeenabdulhaleem
Copy link
Author

@teolemon Can you help review the PR

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.73504% with 17 lines in your changes missing coverage. Please review.

Project coverage is 95.06%. Comparing base (b9cda65) to head (bd6e2f5).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
folksonomy/routes/product.py 90.00% 9 Missing ⚠️
folksonomy/routes/auth.py 91.66% 5 Missing ⚠️
folksonomy/utils/auth.py 90.90% 2 Missing ⚠️
folksonomy/routes/stats.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files           5       10    +5     
  Lines         324      405   +81     
=======================================
+ Hits          308      385   +77     
- Misses         16       20    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good and clean, thanks @nasredeenabdulhaleem, but merging it now, in this GSoC period, would create a lot of conflict in other PRs

So I'm not sure if we should merge it.

@CharlesNepote what do you think ?

@CharlesNepote
Copy link
Member

Yes it's a good job, but also I would prefer that we achieve this task later on, after many ongoing PRs have been merged.

@nasredeenabdulhaleem
Copy link
Author

ok @alexgarel @CharlesNepote Thank You for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants