Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the JSON response if there are no properties #107

Open
aleene opened this issue Oct 14, 2022 · 4 comments
Open

Clarify the JSON response if there are no properties #107

aleene opened this issue Oct 14, 2022 · 4 comments
Labels

Comments

@aleene
Copy link

aleene commented Oct 14, 2022

Problem

Using the read api when no properties are present, I get a NULL as response. This is not very informative. It is unclear if the request succeeded or not. What happened?

Proposed solution

If there are no properties return with json telling that. It might also be possible that there is no product. Unfortunately reading a non-existing product, creates one. So there will always be a product.

Part of

@aleene aleene added the ✨ enhancement New feature or request label Oct 14, 2022
@teolemon teolemon changed the title Json response JSON response Oct 17, 2022
@teolemon teolemon changed the title JSON response Clarify the JSON response if there are no properties Nov 1, 2022
@teolemon teolemon removed the ✨ enhancement New feature or request label Oct 19, 2024
@OmH3
Copy link

OmH3 commented Mar 1, 2025

Hi @aleene ,

I'd like to take this issue and will try to complete it before my exams (March 4-7). If needed, I may take some extra time after exams for final touches. Let me know if that works!

Thanks!

@Clasherzz
Copy link

Clasherzz commented Mar 1, 2025

Would also love to work on this issue if possible

@kirtanchandak
Copy link
Contributor

working on this, we can return empty list [] is there is no data instead of null

@kirtanchandak
Copy link
Contributor

@CharlesNepote related to the comments you added - #234

alexgarel pushed a commit that referenced this issue Mar 13, 2025
Returns - [] for all GET API responses if the desired output is not
found


### Fixes bug(s)
- #120
- #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

5 participants