fix: Returns a JSON response if desired result is not found (#234)

Returns - [] for all GET API responses if the desired output is not
found


### Fixes bug(s)
- #120
- #107

Author: kirtanchandak

folksonomy/api.py

@@ -291,8 +291,12 @@ async def product_stats(response: Response,
     # )
     # out2 = await cur.fetchone()
     # import pdb;pdb.set_trace()
-    return JSONResponse(status_code=200, content=out[0], headers={"x-pg-timing":timing})
 
+    return JSONResponse(
+        status_code=200,
+        content=out[0] if out and out[0] is not None else [],
+        headers={"x-pg-timing": timing}
+    )
 
 @app.get("/products", response_model=List[ProductList])
 async def product_list(response: Response,
@@ -320,8 +324,12 @@ async def product_list(response: Response,
         params
     )
     out = await cur.fetchone()
-    return JSONResponse(status_code=200, content=out[0], headers={"x-pg-timing":timing})
 
+    return JSONResponse(
+        status_code=200,
+        content=out[0] if out and out[0] is not None else [],
+        headers={"x-pg-timing": timing}
+    )
 
 @app.get("/product/{product}", response_model=List[ProductTag])
 async def product_tags_list(response: Response,
@@ -340,9 +348,13 @@ async def product_tags_list(response: Response,
         (product, owner),
     )
     out = await cur.fetchone()
-    return JSONResponse(status_code=200, content=out[0], headers={"x-pg-timing": timing})
-
 
+    return JSONResponse(
+        status_code=200,
+        content=out[0] if out and out[0] is not None else [],
+        headers={"x-pg-timing": timing}
+    )
+    
 @app.get("/product/{product}/{k}", response_model=ProductTag)
 async def product_tag(response: Response,
                       product: str, k: str, owner='',
@@ -379,10 +391,12 @@ async def product_tag(response: Response,
             (product, owner, key),
         )
     out = await cur.fetchone()
-    if out:
-        return JSONResponse(status_code=200, content=out[0], headers={"x-pg-timing": timing})
-    else:
-        return JSONResponse(status_code=404, content=None)
+    
+    return JSONResponse(
+        status_code=200,
+        content=out[0] if out and out[0] is not None else [],
+        headers={"x-pg-timing": timing}
+    )
 
 
 @app.get("/product/{product}/{k}/versions", response_model=List[ProductTag])
@@ -407,7 +421,13 @@ async def product_tag_list_versions(response: Response,
         (product, owner, k),
     )
     out = await cur.fetchone()
-    return JSONResponse(status_code=200, content=out[0], headers={"x-pg-timing": timing})
+
+    return JSONResponse(
+        status_code=200,
+        content=out[0] if out and out[0] is not None else [],
+        headers={"x-pg-timing": timing}
+    )
+    
 
 
 @app.post("/product")
@@ -569,8 +589,12 @@ async def keys_list(response: Response,
         (owner,)
     )
     out = await cur.fetchone()
-    return JSONResponse(status_code=200, content=out[0], headers={"x-pg-timing": timing})
 
+    return JSONResponse(
+        status_code=200,
+        content=out[0] if out and out[0] is not None else [],
+        headers={"x-pg-timing": timing}
+    )
 
 @app.get("/values/{k}", response_model=List[ValueCount])
 async def get_unique_values(response: Response,

tests/test_main.py

@@ -297,8 +297,7 @@ def test_product_missing(with_sample):
     with TestClient(app) as client:
         response = client.get("/product/0000000000000")
         assert response.status_code == 200
-        assert response.json() == None
-        return response.json()
+        assert response.json() == []
 
 
 def test_product_key(with_sample):
@@ -326,8 +325,8 @@ def test_key_stripped_on_get(with_sample):
 def test_product_key_missing(with_sample):
     with TestClient(app) as client:
         response = client.get(f"/product/{BARCODE_1}/not-existing")
-        assert response.status_code == 404
-        assert response.json() == None
+        assert response.status_code == 200
+        assert response.json() == []
 
 
 def test_product_key_versions(with_sample):
@@ -350,7 +349,7 @@ def test_product_key_versions_missing(with_sample):
     with TestClient(app) as client:
         response = client.get(f"/product/{BARCODE_3}/not-existing/versions")
         assert response.status_code == 200
-        assert response.json() == None
+        assert response.json() == []
 
 
 def test_products_stats_key(with_sample):