Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import assertions when importing store #446

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sujitha-av
Copy link

Description

When importing a store, we usually import the model and the tuples from the file. But these changes enable us to also import the assertions (only Check assertions) from the Model Tests as a part of the store import.

References

Open issue - 224

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@sujitha-av sujitha-av requested a review from a team as a code owner January 27, 2025 16:59
@sujitha-av
Copy link
Author

sujitha-av commented Jan 27, 2025

fixing the linting tomorrow

@sujitha-av
Copy link
Author

need some help with this - running golangci-lint gives
cmd/store/import_test.go:7:1: File is not properly formatted (goimports)
but running goimports separately does not seem to be catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant