Fix load scaling in predefined_conventional_loads_by_sector (issue #471) #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tunnel internally
- Check if the database host contains 'toep' by examining engine.url.host. - If connected to a TOEP database, apply logic to translate table names accordingly.
…nnel-limitations' into project/411-LoMa
…orts-not-working-ssh-tunnel-limitations' into project/411-LoMa
- Automatically set `EDisGo.TimeSeries.timeindex` to the default year of the database if it is empty. # - Added a logger warning to inform users about the default behavior and recommend setting the `timeindex` explicitly using `EDisGo.set_timeindex()`. # On branch feature/openego#456-feature-set-default-timeindex-in-edisgoset_time_series_active_power_predefined
…re-set-default-timeindex-in-edisgoset_time_series_active_power_predefined Fix missing timeindex in set_time_series_active_power_predefined
…x in set_time_series_active_power_predefined
…re-set-default-timeindex-in-edisgoset_time_series_active_power_predefined Overwrite timeindex if given timeindex differs from existing timeinde…
…re-set-default-timeindex-in-edisgoset_time_series_active_power_predefined add logging and correct timeindex variable handling
…se-imports-not-working-ssh-tunnel-limitations
…re-set-default-timeindex-in-edisgoset_time_series_active_power_predefined Feature/openego#456 feature set default timeindex in edisgoset time series active power predefined
…ompatibility-with-egon-project-data' into project/411-LoMa
…orts-not-working-ssh-tunnel-limitations' into project/411-LoMa
- Replaced direct use of copy.deepcopy with custom copy method in two places. - Added a new `copy` method to the `EDisGo` class, supporting both shallow and deep copies while excluding the SQLAlchemy engine from being copied. - Ensured proper restoration of the SQLAlchemy engine after copying.
…ase-imports-not-working-ssh-tunnel-limitations Refactor object copying in EDisGo class
…on to allow networks without switches
… by nominal power
…strict function if None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the load time series scaling in
predefined_conventional_loads_by_sector.What changed
annual_consumption.p_set, analogous to the handling of generators.p_setis available for all affected loads.Why
annual_consumptionto scale a power time series is inconsistent and misleading, especially when generators are already scaled by nominal power.p_set.Related issue