Skip to content

Add discussion service to access permission and access provider #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
salman2013 wants to merge 2 commits into
base: salman/extract-discussion-block
Choose a base branch
from
Draft

Add discussion service to access permission and access provider #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35eccea
chore: access discussion permission and setting with service
salman2013 Jan 26, 2026
f971dab
fix: update service name
salman2013 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions xblocks_contrib/discussion/discussion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def is_discussion_enabled(course_id): # pylint: disable=unused-argument


@XBlock.needs("i18n")
@XBlock.needs("discussion_config_service")
@XBlock.wants("user")
# pylint: disable=abstract-method
class DiscussionXBlock(XBlock, StudioEditableXBlockMixin, LegacyXmlMixin):
Expand Down Expand Up @@ -102,6 +103,13 @@ class DiscussionXBlock(XBlock, StudioEditableXBlockMixin, LegacyXmlMixin):

has_author_view = True # Tells Studio to use author_view

@property
def discussion_config(self):
"""
Returns discussion service.
"""
return self.runtime.service(self, 'discussion_config_service')

@property
def course_key(self):
return getattr(self.scope_ids.usage_id, 'course_key', None)
Expand All @@ -111,10 +119,7 @@ def is_visible(self):
"""
Discussion Xblock does not support new OPEN_EDX provider
"""
# TO-DO: Need to fix import issues
# provider = DiscussionsConfiguration.get(self.course_key)
# return provider.provider_type == Provider.LEGACY
return True
return self.discussion_config.is_discussion_visible(self.course_key)

@property
def django_user(self):
Expand Down Expand Up @@ -198,9 +203,10 @@ def has_permission(self, permission): # pylint: disable=unused-argument
:param str permission: Permission
:rtype: bool
"""
# TO-DO: Need to fix import issues
# return has_permission(self.django_user, permission, self.course_key)
return True
if self.discussion_config:
return self.discussion_config.has_permission(self.django_user, permission, self.course_key)
else:
return False

def student_view(self, context=None):
"""
Expand Down Expand Up @@ -233,7 +239,7 @@ def student_view(self, context=None):
),
)

if is_discussion_enabled(self.course_key):
if self.discussion_config.is_discussion_enabled:
context = {
'discussion_id': self.discussion_id,
'display_name': self.display_name if self.display_name else _("Discussion"),
Expand Down