fix(authn): include user email in inactive-account login error#38808
fix(authn): include user email in inactive-account login error#38808Chessing234 wants to merge 1 commit into
Conversation
Ensure inactive-user login failures always return the account email in the JSON response so the login UI can display the activation message. Fixes openedx#37406. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the pull request, @Chessing234! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Fixes #37406
Summary
When an inactive user attempts to log in, the login page should show their email in the activation reminder. The API now always includes the user's email in the inactive-user error response, even when authentication returns no active session user object.
Changes
emailto inactive-user error context in_log_and_raise_inactive_user_auth_erroremailfield in login error responsestest_login_not_activated_includes_user_emailTest plan
emailis present for inactive-user login failuresMade with Cursor