chore: clean up test_root/data/ and ignore generated artifacts#38805
Open
feanil wants to merge 1 commit into
Open
chore: clean up test_root/data/ and ignore generated artifacts#38805feanil wants to merge 1 commit into
feanil wants to merge 1 commit into
Conversation
At some point output from a test run got accidentally checked into test_root/data/, which made it hard to fully gitignore the other test-run artifacts that land there. Delete the orphan files and switch the directory to allow-list mode: ignore everything by default and re-include the video/ fixtures we want to keep on purpose. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bmtcril
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_root/data/issettings.GITHUB_REPO_ROOTin test settings, so course-import code (cms/djangoapps/contentstore/.../tasks.py::import_olx) writes per-course subdirectories there namedurlsafe_b64encode(repr(course_key))whenever an import test runs. Nothing cleans them up, and at some point output from one of those test runs got accidentally checked in (inc1b701309b— an unrelated 2023 video-editor feature PR), which made it hard to fully gitignore the rest of the generated artifacts that land there.This PR:
test_root/data/Q291.../good.tar.gz× 2 + the now-redundanttest_root/data/.gitkeep). The import tests build their owngood.tar.gzin atempfile.mkdtemp()at setup time and don't reference any path undertest_root/data/, so the orphans aren't used..gitignore: ignore everything intest_root/data/by default and explicitly re-includevideo/(the fixture set we want to keep). New fixture additions need an extra!line.