fix: include user email in inactive-user login error response#38803
fix: include user email in inactive-user login error response#38803Chessing234 wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @Chessing234! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Return the inactive user's email address in the login API response so the activation reminder on the login page shows the correct address. Fixes openedx#37406 Co-authored-by: Cursor <cursoragent@cursor.com>
b08ee7e to
6cb6877
Compare
Fixes #37406
When an unactivated user signs in, the login error handler was not setting the
emailfield from the authenticated user object, so the activation reminder rendered as "We just sent an activation link to" with nothing after it.Restore the inactive-user branch so
response_content["email"]usesuser.email.